You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 7 Next »


Document the state by adding a label to the FLIP page with one of "discussion", "accepted", "released", "rejected".

Discussion threadhere
Vote threadhere (<- link to https://lists.apache.org/list.html?dev@flink.apache.org)
JIRAhere (<- link to https://issues.apache.org/jira/browse/FLINK-XXXX)
ReleaseTBD

Please keep the discussion on the mailing list rather than commenting on the wiki (wiki discussions get unwieldy fast).

Motivation

The goal of this FLIP is to add additional fields to Sink#InitContext to expose ExecutionConfig (or at least the ExecutionConfig#isObjectReuseEnabled) and JobID.

This is necessary to migrate the current JdbcSink to the SinkV2 (FLIP-239 -> FLINK-25421) more specifically in order to be able to reuse the current code:

  • the JdbcOutputFormat which today uses RuntimeContext to get the ExecutionConfig#isObjectReuseEnabled. 
  • the SemanticXidGenerator (for Xa-Sink) needs JobID to create the Xid.


This would be necessary to another connectors as well, for example KafkaTableSink uses isObjectReuseEnabled too.

Public Interfaces

  • We want to extend the Sink#InitContext to provide the ExecutionConfig and JobID.

Proposed Changes

We propose to expose the ExecutionConfig, so that all configs on this will be available, but we could only expose the isObjectReuse if we want to expose only the required configuration.

InitContext
@PublicEvolving
public interface Sink<InputT> extends Serializable {
    ... current methods
 
    @PublicEvolving
    public interface InitContext {
        ... current methods

        /**           
         * Returns the {@link org.apache.flink.api.common.ExecutionConfig} for the currently executing job.
         */
        ExecutionConfig getExecutionConfig();

        /**
         * The ID of the current job. Note that Job ID can change in particular upon manual restart.
         * The returned ID should NOT be used for any job management tasks.
         */
        JobID getJobId();     
	}
}  


Compatibility, Deprecation, and Migration Plan

  • The change only one additional method so no impact on existing code.

Test Plan

These simple API changes will be covered by extending unit and integration tests.

Rejected Alternatives

No alternatives yet.

  • No labels