You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 4 Next »

  • Please make sure you use the external jira for most of the design updates (adding detailed descriptions, comments, etc)

  • Create a patch and upload to the external jira

  • As soon as you think the patch is ready for review please mark the patch as Patch Available by clicking on the “Submit Patch” button

  • Request one of the Ambari Team Committers to review the patch

  • On review completion and any further updates, the reviewer adds a comment to the external jira approving the patch (“+1”)

  • NOTE: On backend changes reviewers please make sure tests are attached to each jira. If there is special case, please make sure there is a good explanation for not having a test case.

  • After the reviewer has approved the patch, the person who is assigned the jira is responsible for getting it committed to external jira - so in case you do not have commit rights please find one of your team members to do it for you.

  • Use https://cwiki.apache.org/confluence/display/AMBARI/How+to+Commit on how to commit to svn

  • After committing to svn, resolve the external and internal Jiras as Fixed.


 

CV Patches:

  • All unit tests must pass after applying the patch.

  • Also, any new files must contain Apache 2.0 license headers

  • Do not use tabs.  Set your IDE to convert tabs into spaces instead.

  • Do not use non-ASCII characters

  • Do not use Windows newline characters.  Use UNIX newline characters instead.

  • Make sure that you are checking in all dependencies/new files; after committing, the build should work on clean checkout

  • Make sure that the clock is set up correctly on your machine.


 

Ambari uses ReviewBoard for code reviews.

All Ambari related code reviews, at ReviewBoard, can be found at https://reviews.apache.org/groups/Ambari/

Using ReviewBoard

You may need to create a ReviewBoard login. Once you login add yourself to the "Ambari" group.

To submit a patch for review

  1. Click on "New Review Request"
  2. Select "ambari" from the drop-down and upload a diff file
  3. Go to the next page
    1. Add a summary
    2. Names of two reviewers (only one +1 is necessary for commit)
    3. Select ambari as the group
    4. Type in the Ambari JIRA id
    5. Add description of the fix
    6. Add a link to the ReviewBoard URL to the JIRA
    7. [if applicable] Fill the optional fields as needed.
    8. [if applicable] Add the unit test summary to the request
  4. Publish the review
  5. After the review is marked "Ship It" you can optionally attach the final patch to the JIRA.

For reviewers

Reviewers, after you are satisfied with the patch, mark "Ship It" through the ReviewBoard as well as add a "+1" to the JIRA.

  • No labels