You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 6 Next » 

WIP from VB

Since Sqoop2 is primarily JAVA, we will be using the google JAVA coding standards for the most parts.

Google JAVA coding standards

Here are the list of items that we follow strictly.

Column Limit and Line Wrapping

https://google-styleguide.googlecode.com/svn/trunk/javaguide.html#s4.4-column-limit

We will use the 100 character limit. 

Import Order and Grouping

  1. All static imports in a single group
  2. com.* imports (only if this source file is in the com.google package space)
  3. Third-party imports, one group per top-level package, in ASCII sort order
    • for example: android, com, junit, org, sun
  4. java imports
  5. javax imports

 

Here are a few more things we like you to be consistent with

  • All test classes should be in the exact same package hierarchy as the source java class
  • All test classes should begin with Test for instance TestCSVInternmediateFormat.java instead of CSVIntermediateFormatTest

 

Before you get on to uploading the patch, also read this wiki that will help with getting through larger feature reviews quicker

Sqoop 2 Review Board Guidelines

  • No labels