You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 9 Next »

Release Retrospective to correct Apache MXNet source licenses in post MXNet 1.0 release.

References:

  1. https://github.com/apache/incubator-mxnet/issues/8913
  2. Email from Henri Yandell
  3. Email from Justin McClean

 

NoCategoryProblemSource FilesSuggested byLeadsComments
1.
Source 
tree
* Move the various git submodules into third-party/ or similar so it's
simpler to see what is Apache original source when we review a release.
submodules
Henri Yandell
  
2.
Copyright
* Deal with the Copyright statements in perl-package (copyright holder has
approved doing this)
perl-package
Henri Yandell
  
3.
Formatting
* Lots of whitespace on end of NOTICE
NOTICE
Henri Yandell
Meghna
PR in Review
4.
Comments
* Comment added to CODEOWNERS to explain the file so we don't cause
community problems
CODEOWNERS
Henri Yandell
  
5.
Licenses
* There was a suggestion to simplify the LICENSE to not explicitly list
which packages are under each license. Something to consider.
LICENSE
Henri Yandell
  
       
6.
Specific 
Files
* Resolve License Header - if you follow the URL mentioned in the file it is unclear 
if the code came form that site or was written for the project by the author
of that site.
example/image-classification/predict-cpp/image-classification-predict.cc
Justin McClean
  
7.
Specific 
Files
* Resolve License Header - This file has two license headers
tools/license_header.py
Justin McClean
Meghna
Possibly RAT got confused 
by the matching string
8.
Specific 
Files
* Check LICENSE - Listed as Apache License in the LICENSE but is it MIT license?
nnvm/tvm/HalideIR/LICENSE
   
9.
Specific 
Files
* Check LICENSE - Listed as Apache License in the LICENSE but is it MIT license?
example/rcnn/rcnn/cython/gpu_nms.pyx
   
10.
Specific 
Files
* Check LICENSE - Listed as Apache License in the LICENSE but is it MIT license?
example/rcnn/rcnn/cython/gpu_nms.pyx
   
11.
Specific 
Files
* Check LICENSE - Listed as Apache License in the LICENSE but is it MIT license?
example/rcnn/rcnn/cython/cpu_nms.pyx
   
12.
Specific 
Files
* Missing License Header - is it Apache License?
perl-package/AI-NNVMCAPI/Makefile.PL
   
13.
Specific 
Files
* Add to LICENSE - BSD license
src/operator/contrib/ctc_include/contrib/moderngpu/include/mgpudevice.cuh
   
14.
Specific 
Files
* Add to LICENSE - A dozen files here are BSD
src/operator/contrib/ctc_include/contrib/moderngpu/include/device/
   
15.
Specific 
Files
* Add to LICENSE - BSD license
nnvm/tvm/dmlc-core/cmake/Modules/FindCrypto.cmake
   
16.
Specific 
Files
* Add to LICENSE - BSD license
example/ssd/dataset/pycocotools/coco.py
   
17.
Specific 
Files
* Add to LICENSE - 6 files are BSD licensed
example/rcnn/rcnn/pycocotools
   
18.
Specific 
Files
* Add to LICENSE - BSD license
dmlc-core/cmake/Modules/FindCrypto.cmake
   
19.
Specific 
Files
* Add to LICENSE - BSD license
cub/experimental/spmv_compare.cu
   
20.
Specific 
Files
* Incorrect License Header - Has ASF header but is it BSD
prepare_mkl.sh
   
21.
Specific 
Files
* Incorrect License Header - Has ASF header but is it BSD
src/operator/nn/im2col.h
src/operator/nn/im2col.c
   
22.
Specific 
Files
* Incorrect License Header - Has ASF header but is it BSD
src/operator/contrib/nn/deformable_im2col.h
src/operator/contrib/nn/deformable_im2col.c
   
 23.
Specific 
Files
* Incorrect License Header - Has ASF header but is it BSD
src/operator/contrib/ctc_include/contrib/moderngpu/include/mgpuenums.h
   
24. 
Specific 
Files
* Incorrect License Header - Has ASF header but is it BSD
example/ssd/dataset/pycocotools/coco.py
  Yes, looks like BSD license
25. 
Specific 
Files
* Incorrect License Header - Has ASF header but is it MIT
example/rcnn/rcnn/cython/setup.py
  Yes, looks like MIT license
26.
Specific 
Files
* Incorrect License Header - Has ASF header but is it MIT
example/rcnn/rcnn/cython/nms_kernel.cu
   Yes, looks like MIT license
27.
Specific 
Files
* Incorrect License Header - Has ASF header but is it MIT
example/rcnn/rcnn/cython/setup.py
   Yes, looks like MIT license
       
       
       
       
       
       
       
       
       
       
       
       
       
       
       
  • No labels