You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 32 Next »

Release Retrospective to correct Apache MXNet source licenses in post MXNet 1.0 release.

References:

  1. https://github.com/apache/incubator-mxnet/issues/8913
  2. Email from Henri Yandell
  3. Email from Justin McClean

 

NoCategoryProblemSource FilesSuggested byLeadsComments
1.
Source 
tree
* Move the various git submodules into third-party/ or similar so it's
simpler to see what is Apache original source when we review a release.

submodules
Henri Yandell
Haibin Lin
 
2.

Copyright

* Deal with the Copyright statements in perl-package (copyright holder has approved doing this)

perl-package

Henri Yandell

Henri YandellFixed by Henri in this PR -
https://github.com/apache/incubator-mxnet/pull/9191
3.

Formatting

* Lots of whitespace on end of NOTICE

NOTICE

Henri Yandell

Meghna Baijal
PR Merged
https://github.com/apache/incubator-mxnet/pull/9459
4.
Comments
* Comment added to CODEOWNERS to explain the file so we don't cause
community problems
CODEOWNERS
Henri Yandell
Steffen Rochel 
5.
LICENSE
* There was a suggestion to simplify the LICENSE to not explicitly list
which packages are under each license. Something to consider.
LICENSE
Henri Yandell
Meghna Baijal
If this is done, it would resolve points 8-11 and 13-19 of this wiki
 
LICENSE
* Update the Paths to license files once submodules are moved
LICENSE
Meghna Baijal
Haibin Lin 
 
Automated Check
* Update the license_header.py script instead of manual exclusions
tools/license_header.py
Meghna BaijalMeghna Baijal 
       
  
ISSUES IN SPECIFIC FILES
    
6.
Specific 
Files

* Resolve License Header - if you follow the URL mentioned in the file it is unclear

if the code came form that site or was written for the project by the author

of that site.

example/image-classification/predict-cpp/image-classification-predict.cc

Justin McClean
  
7.
Specific 
Files

* Resolve License Header - This file has two license headers

tools/license_header.py

Justin McClean
Meghna Baijal
Possibly RAT got confused 
by the matching string. Does not need a fix.
8.
Specific 
Files

* Check LICENSE - Listed as Apache License in the LICENSE but is it MIT license?

nnvm/tvm/HalideIR/LICENSE

Justin McClean
Meghna BaijalSubmodule, not to be fixed as part of MXNet release
9.
Specific 
Files
* Check LICENSE - Listed as Apache License in the LICENSE but is it MIT license?example/rcnn/rcnn/cython/gpu_nms.pyx
Justin McClean
Meghna BaijalRemoved details from LICENSE. Correctly added MIT license header and in LICENSE file in directory
10.
Specific 
Files
* Check LICENSE - Listed as Apache License in the LICENSE but is it MIT license?example/rcnn/rcnn/cython/gpu_nms.pyx
Justin McClean
Meghna BaijalRemoved details from LICENSE. Correctly added MIT license header and in LICENSE file in directory
11.
Specific 
Files
* Check LICENSE - Listed as Apache License in the LICENSE but is it MIT license?example/rcnn/rcnn/cython/cpu_nms.pyx
Justin McClean
Meghna BaijalRemoved details from LICENSE. Correctly added MIT license header and in LICENSE file in directory
12.
Specific 
Files

* Missing License Header - is it Apache License?

perl-package/AI-NNVMCAPI/Makefile.PL

Justin McClean

  
13.
Specific 
Files

* Add to LICENSE - BSD license

src/operator/contrib/ctc_include/contrib/moderngpu/include/mgpudevice.cuh

Justin McClean
 Add BSD to license. Packages not named in LICENSE anymore
14.
Specific 
Files

* Add to LICENSE - A dozen files here are BSD

src/operator/contrib/ctc_include/contrib/moderngpu/include/device/

Justin McClean
 Add BSD to license. Packages not named in LICENSE anymore
15.
Specific 
Files

* Add to LICENSE - BSD license

nnvm/tvm/dmlc-core/cmake/Modules/FindCrypto.cmake

Justin McClean
Meghna Baijal 
16.
Specific 
Files
* Add to LICENSE - BSD license
example/ssd/dataset/pycocotools/coco.py
Justin McClean
  
17.
Specific 
Files
* Add to LICENSE - 6 files are BSD licensed
example/rcnn/rcnn/pycocotools
Justin McClean
  
18.
Specific 
Files
* Add to LICENSE - BSD license
dmlc-core/cmake/Modules/FindCrypto.cmake
Justin McClean
  
19.
Specific 
Files
* Add to LICENSE - BSD license
cub/experimental/spmv_compare.cu
Justin McClean
 
Cub is added to LICENSE 
but is that a BSD license?
20.

Specific

Files

* Incorrect License Header - Has ASF header but is it BSD

prepare_mkl.sh

Justin McClean
 Does not say BSD, add?
21.

Specific

Files

* Incorrect License Header - Has ASF header but is it BSD

src/operator/nn/im2col.h
src/operator/nn/im2col.cuh

Justin McClean
 
Created PR, in review 
https://github.com/apache/incubator-mxnet/pull/9462
22.

Specific

Files

* Incorrect License Header - Has ASF header but is it BSD

src/operator/contrib/nn/deformable_im2col.h
src/operator/contrib/nn/deformable_im2col.cuh

Justin McClean
 
First was fixed for 1.0.0 here - https://github.com/apache/incubator-mxnet/pull/9170
Second in PR review - https://github.com/apache/incubator-mxnet/pull/9462
 23.
Specific Files* Incorrect License Header - Has ASF header but is it BSD
src/operator/contrib/ctc_include/contrib/moderngpu/include/mgpuenums.h
Justin McClean
 License seems to be correct. No ASF header.
24. 

Specific

Files

* Incorrect License Header - Has ASF header but is it BSD

example/ssd/dataset/pycocotools/coco.py

Justin McClean
 

Removed ASF header in PR
ADD BSD License text??

25. 

Specific

Files

* Incorrect License Header - Has ASF header but is it MIT

example/rcnn/rcnn/cython/setup.py

Justin McClean
 

Removed ASF Header in PR
Add MIT license Text?

26.

Specific

Files

* Incorrect License Header - Has ASF header but is it MIT

example/rcnn/rcnn/cython/nms_kernel.cu

Justin McClean
 
Removed ASF Header in PR
Add MIT license Text?
27.

Specific

Files

* Incorrect License Header - Has ASF header but is it MIT

example/rcnn/rcnn/cython/setup.py

Justin McClean
 
 Repeat
       
  
APACHE RAT CHECK FAILURES
    
28.
RAT Failure
* Fix Submodules - RAT detected almost 2000 files with unknown licenses in submodules
Submodules (nnvm, dlpack, 3rdparty, ps-lite, mshadow) and R-package
  
Decision needed on how to handle submodule licenses
29.
RAT Failure
* Check Docs - RAT detected almost 200 files with unknown licenses in the Docs directory
/docs
   
30.
RAT Failure
* Fix dockerfiles without license headers
/docker
 
Meghna Baijal
 
31.
RAT Failure
* Fix docker_multiarch - unknown license header
/docker_multiarch
   
32.
RAT Failure
* Fix scala-package - unknown license
/scala-package
   
33.
RAT Failure
* Fix tools
/tools
   
34.
RAT Failure
* Fix tests
/tests
   
35.
RAT Failure
* Fix examples
/examples
   
36.
RAT Failure
* Check file types that can be ignored - .txt; .js, .md, .json, .yml, .*, 
/
 
Meghna Baijal
 
37.
RAT Failure
* Fix ctc_include
src/operator/contrib/ctc_include
   
  
 
    
 
 
 
    
  
 
    

 

Apache Licensing Policies:

  • No labels