Current state: Accepted
Discussion thread: here
Vote thread: here
JIRA: here
Please keep the discussion on the mailing list rather than commenting on the wiki (wiki discussions get unwieldy fast).
Since KIP-382 (MirrorMaker 2.0), a new method commitRecord was included in SourceTask class to be called by the worker adding a new parameter with the record metadata. The old commitRecord method is called from the new one and is not called anymore (it's preserved just for backwards compatibility).
package org.apache.kafka.connect.source; // imports public abstract class SourceTask implements Task { protected SourceTaskContext context; // ... /** * .... * @deprecated Use {@link #commitRecord(SourceRecord, RecordMetadata)} instead. */ @Deprecated public void commitRecord(SourceRecord record) throws InterruptedException { } // ... |
I suggest to deprecate commitRecord(SourceRecord)
in class SourceTask.
As we are only deprecating a method in a class, there are not backward compatibility concerns.
None.