Release manager and release co-manager (if manager is not a committer) are responsible for:
Draft release notes which should include the list of new features and bug fixes, along with limitations, known issues, etc. Seek help from committers on @dev to achieve good coverage of all important fixes/API changes in the release.
#!/bin/bash # to get a list of commits since <date> git log --pretty=format:"%h - %cn, %cd : %s" --no-merges --since="2017-09-01" > commits.txt # To get a list of committers since <date> git shortlog -sne --since="10 Aug 2017" |
Alternatively, you can use the script here to create groups of commits based on commit comments.
Check if this release has to go out on a blog on Medium (Sukwon) beforehand. If so, keep time to work on the blog post as this may take a while longer. This blog post needs to go through multiple reviews. |
You can find references of sent emails, for example for the most recent release, in the apache archive (or your inbox) as well:
After every release, the community should decide on a list of features to deliver for the following release. When the clear target date for a release has been estimated, the release lead should inform the community of the release schedule. All features which the community wishes to include in the release should be merged and tested successfully before the date of the first release candidate. The first release candidate should be on a commit which passed builds from at least 3 days before cutting the release candidate. This will make the release lead's job easier. Below is a template for the announcement:
To: dev@mxnet.apache.org Dear MXNet community, I will be the release manager for the upcoming $release release. (Optional: $CO-RM will be co-managing the release and providing help from the committers side.) Feel free to add any other comments/suggestions. Thanks, [1] $release-notes-link |
Make sure all files have correct License headers and the top level LICENSE file has been updated.
The top level LICENSE and NOTICE files are correct and dependency licenses are acceptable
Refer to the following Links
At least 3 days prior to cutting the first release candidate, check the version number and address other changes that the release depends on.
Update the version number if it's not reflecting the new release version. Here is a previous version update PR (https://github.com/apache/incubator-mxnet/pull/19196).
make sure no broken/non-existing links are added to the master/v1.x branch.
Check with the website lead and docs lead that all necessary updates have made it into the release branch
Create a RSA GPG key of length 4096, upload it to the public server, and add it to the KEYS file (do this process once for each release lead):
See more detailed instructions on creating the key here: https://www.apache.org/dev/openpgp.html#generate-key. Instructions for updating the KEYS file can at the beginning of the KEYS file. Note that you must use apache email instead of personal email for the key. The following instructions shows how to update the key using svn.
# checkout the apache mxnet repo svn co https://dist.apache.org/repos/dist/release/incubator/mxnet apache-mxnet cd apache-mxnet # update the KEYS file ... # commit the update svn commit -m “update keys file for xxx ” --username your_username --password your_passwd |
Note: From version 1.3 all branches are created with a name v1.3.x to make patch releases easier. For patch releases cutting a new branch is not necessary. Fixes for patch releases should be merged to v#.#.x branch and latest commit should be tagged with an exact version number, ie v1.3.1.
# checkout clean master branch git clone https://github.com/apache/incubator-mxnet.git cd incubator-mxnet git branch v1.4.x git push --set-upstream origin v1.4.x |
Once all the PRs have been merged the final commit hash on the release branch must be tested. (You should begin testing as soon as the release branch is created, but make sure it is run at least once on the final commit)
Following jobs are run as a part of the nightly tests:
These jobs should already contain needed branches if they are cut. If not, check the jobs configuration. These are triggered by DailyTrigger. Either wait until the jobs have been triggered or trigger them manually.
Note : Currently (master)|(^v.*) ensures all release branches starting with v should be scanned & included into the pipeline.
Backward Compatibility checker (can skip this step).
Some jobs might take up to 4-5 hours, so plan accordingly.
In case of a failure of any job, check the console logs, the newly added PRs and try and resolve issues or contact community for a fix (on @dev list, for example).
Ensure that PR verification is enabled for the target release branch (This is automatically ensured by , no special actions needed)
Ensure that nightly tests are enabled for the target release branch, for example v.1.3.x NightlyTestsForBinaries, v1.3.x NightlyTests
Ensure that release branch is in the daily reports (contact Unknown User (marcoabreu) )
make sure the RAT check passes (it's already part of the verification pipeline as a stage, no special actions needed)
Go to the GitHub repositories “releases” tab
Click “Draft a new release”
Tag all the dependent submodules for every MXNet release. If a code-change (e.g. bug-fix) is required to a dependent sub-module then we take a branch from the tag and apply the code-change only to the branch for the sub-module so that the change is minimal. This should allow the MXNet release process to have better convergence towards a stable release.
Clone the Repo and checkout the release branch
Remove R-package until the licensing issue is resolved
Remove all the .git files
Remove all other files of the form .* (eg .travis, .DS_Store etc)
on MacOS use gnu-tar
Try to untar it in a different type of machine and try a classic build with `make`. Follow build instructions in the "Build from Source" section http://mxnet.incubator.apache.org/get_started/install.html
git clone git@github.com:apache/incubator-mxnet.git apache-mxnet-src-0.12.0.rc0-incubating git checkout v0.12.0 git submodule update --init --recursive git checkout 0.12.0.rc0 rm -rf R-package rm -rf .DS_Store rm -rf CODEOWNERS find . -name ".git*" -print0 | xargs -0 rm -rf brew install gnu-tar gtar -czvf apache-mxnet-src-0.12.0.rc0-incubating.tar.gz apache-mxnet-src-0.12.0.rc0-incubating |
Details here: http://www.apache.org/dev/release-signing.html#openpgp-ascii-detach-sig
gpg --armor --output apache-mxnet-src-#.#.#-incubating.tar.gz.asc --detach-sig apache-mxnet-src-#.#.#-incubating.tar.gz shasum -a 512 apache-mxnet-src-#.#.#-incubating.tar.gz > apache-mxnet-src-#.#.#-incubating.tar.gz.sha512 |
# Checkout the Apache directory in Apache distribution SVN "dev" repo $ svn co https://dist.apache.org/repos/dist/dev/incubator/mxnet # select p # Make directory for this RC in the above directory $ cd mxnet $ mkdir #.#.#.rc0 # Move artifacts into this folder $ cp ../apache-mxnet-src-#.#.#.rc0-incubating.tar.gz* #.#.#.rc0 $ svn add #.#.#.rc0 $ svn commit -m "Add mxnet-#.#.#.rc0" --username "lxn2" |
As per the Apache documentation, verify that the release candidate artifacts satisfy the following:
PGP signatures and SHA256 checksum verification
svn co https://dist.apache.org/repos/dist/dev/incubator/mxnet && cd mxnet/#.#.#.rc0 brew install gpg coreutils wget https://downloads.apache.org/incubator/mxnet/KEYS gpg --import ./KEYS |
gpg --verify ./apache-mxnet-src-0.11.0.rc3-incubating.tar.gz.asc gsha512sum --check ./apache-mxnet-src-0.11.0.rc1-incubating.tar.gz.sha512 |
Download the package that was just uploaded to svn as above.
Test that a build is successful - spinning up a deep learning Ubuntu AMI will give you an environment with all dependencies to build. You can build MXNet from source or from CI dockers. For example:
pip install --user -r ci/requirements.txt python ci/build.py -p ubuntu_gpu |
If possible, run a simple (MNIST) test to verify the src.
Edit the release tag from Step 1.7, and upload the release artifacts from Step 1.9 (which were verified in 1.10-1.11).
After creating RC, give 2 days to build scala/ R packages if needed before starting vote on dev@.
The language bindings are released separately from the main MXNet release. To release Scala/Java Clojure and R bindings, follow the guides for the corresponding language bindings. Release manager can ask the help from dev@ to reach owners of different language bindings to do the validation.
Follow the release process to build Scala/Java packages and include the stage repo links in the voting email:
Follow the release process to build Clojure packages and include the stage repo links in the voting email:
Follow the release process to build R packages and include the stage repo links in the voting email:
The full voting process consists of two phases: (1) vote on dev@mxnet.apache.org (3 days) (2) vote on general@incubator.apache.org (3 days). For full documentation refer to the Apache Voting Process. We should cc the incubation mentors in the vote threads to keep them informed.
Our mentors are: Bob Paulin (bob@apache.org), Henri Yandell (bayard@apache.org), Jason Dai (jasondai@apache.org), Markus Weimer (weimer@apache.org), Michael Wall (mjwall@apache.org).
For the dev@ vote, there must be at least 3 binding +1 votes and more +1 votes than -1 votes. Once that quorum has been reached, the vote then moves onto the general@ vote.
To find out if the person has a binding vote visit: http://incubator.apache.org/projects/mxnet.html
Use the email template below to start the vote:
Cc: mentors Dear MXNet community, This is the vote to release Apache MXNet (incubating) version $release. Voting will start $start-date-time and close on $end-date-time, $time-zone. Link to release notes: Link to release candidate: Link to source and signatures on apache dist server: Link to scala packages on the staging repo: * CPU * GPU Please remember to TEST first before voting accordingly:
|
There are 3 ways of getting the source code for the release candidate
Check out tag
Method 1
git clone --recursive https://github.com/apache/incubator-mxnet.git git checkout tags/<tag_name> -b <branch_name> |
Method 2
git clone --recursive https://github.com/apache/incubator-mxnet.git --branch=<tag_name> |
Once checked out, follow the steps to build mxnet from source [1] and then various tests can be run.
It is recommended that contributors test out parts of the MXNet codebase they have touched. This ensures greater coverage of the testing and reduces the risk of running into errors post release.
Note: CPU vs GPU, MKLDNN : ON/OFF, Linux vs Centos vs Windows vs Mac are various configurations possible.
Make sure to verify the build flags before running the tests on the release candidate.
[1] https://mxnet.apache.org/get_started/build_from_source
Cc: mentors I'm happy to announce the results of the vote. This vote passes with <num> +1 votes (<num> binding) and no 0 or -1 votes. +1 votes I'll continue with the release process and the release announcement will follow in the next few days.
[1] https://lists.apache.org/thread.html/<link> |
Should any vote fail to reach quorum or release lead determines that another RC needs to go out, the release lead should triage the issues, create GitHub issues, and move to fix the issues. Once fixed, make changes to NEWS & README.md in case it specifically lists the old RC# number. Start the process for another release candidate. In the new voting email, detail what has changed since the last release candidate. Repeat until the vote passes.
To: dev@mxnet.apache.org We are cancelling this vote because: ... We will address the issues and send out rc#+1 for another vote. Best regards, |
For the vote on general@, anyone can contribute a vote, but only "Incubator PMC" (IPMC) votes are binding.
To pass, there must be 3 binding +1 votes and more +1 votes than -1 votes.
In ASF, votes are open "at least" 72hrs (3 days). If you don't get enough number of binding votes within that time, you cannot close the voting deadline. You need to extend it.
Make sure the dev community is aware of any ASF votes and results so they can be active in the ongoing voting process.
Send out a notice to vote with the template below.
To get the fingerprint of your keys, run `gpg2 --list-keys --fingerprint`
To: general@incubator.apache.org Dear community, This is a call for a releasing Apache MXNet (incubating) #.#.#, release Apache MXNet (incubating) community has voted and approved the release. Vote thread: Result thread: The source tarball, including signatures, digests, etc. can be found at: The tag to be voted upon is #########: The release hash is #########: Release artifacts are signed with the following key: KEYS file available: For information about the contents of this release, see: The vote will be open for 72 hours. [ ] +1 release this package as ######### Best regards, |
Send out an email on general@ in the same voting thread which you sent in previous step to summarize the result. Send out a notice with the vote results with the template below.
To: general@incubator.apache.org |
Once the release candidate passes the vote, we draft the official release on GitHub and rename the release candidate as the official release.
Go to the GitHub repo’s “releases” tab
Click “Draft a new release”
Provide the release tag in the form of “<major>.<minor>.<patch>”
Select the commit by clicking Target: branch > the passing release candidate tag
Copy and paste NEWS change into the description box
First upload to dev and then move to releases as follows:
#create a directory under releases - https://httpd.apache.org/dev/release.html
This process needs to change -> http://www.apache.org/dev/release-download-pages.html
# Step 1: Download and Untar tar -zxvf apache-mxnet-src-0.11.0.rc3-incubating.tar.gz # Step 2: rename (remove the rc) and tar again mv apache-mxnet-src-0.11.0.rc3-incubating apache-mxnet-src-0.11.0-incubating gtar -czvf apache-mxnet-src-0.11.0-incubating.tar.gz apache-mxnet-src-0.11.0-incubating # Step 3: Resign now # Step 4: First upload here - svn mv https://dist.apache.org/repos/dist/dev/incubator/mxnet/0.11.0/ # Step 5: Move from dev to release svn mv https://dist.apache.org/repos/dist/dev/incubator/mxnet/0.11.0/ https://dist.apache.org/repos/dist/release/incubator/mxnet/ --message "0.11.0 release moving from dev to release repo" # Wait 24hours for the src mirroring. The final download page for the announce email is somewhere here (example 0.11.0) - https://www.apache.org/dyn/closer.cgi/incubator/mxnet/0.11.0-incubating/ |
For linux, we can trigger a release pipeline that builds, tests and publishes the pip wheels and python docker images for us with just a few steps:
<branchName>refs/tags/<tagName>For mac, the following automated script can be used to build the wheel.(MacOS machine is required to generate wheels for mac)
#!/bin/bash
# Install brew
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh)"
# Install developement tools
brew install nasm
brew install automake
brew install libtool
brew install ninja
brew install pkg-config
python -m pip install contextvars
python -m pip install numpy
python -m pip install requests
# Clone MXNet
cd $HOME
git clone -b v1.x --single-branch https://github.com/apache/incubator-mxnet.git # Use release tag instead
cd $HOME/incubator-mxnet/
git submodule update --init --recursive
# Set ENV variables and build statically
export IS_RELEASE=True
export mxnet_variant=cpu
echo $(git rev-parse HEAD) >> python/mxnet/COMMIT_HASH
mkdir -p $HOME/pip_build/mxnet-build
cp -r * $HOME/pip_build/mxnet-build
export CODE_DIR=$(pwd)
cd $HOME/pip_build/mxnet-build
CMAKE_STATICBUILD=1 ./tools/staticbuild/build.sh $mxnet_variant pip
# Package wheel
cd $HOME/pip_build
cp -r mxnet-build/tools/pip/* .
python setup.py bdist_wheel
# Copy wheel to $HOME/pip_build
cp $HOME/pip_build/dist/mxnet* $HOME/pip_build
Wheels are publish manually to pypi.
Please note that the release tag is usually created on a branch that's forked from v1.x and master. In that case it may lack some of the latest ci/cd fixes on the v1.x and master branch. We might need to manually port back those fixes for the cd pipeline to work.
Check that the resources are present in http://www.apache.org/dist/incubator/mxnet. It may take a while for them to be visible. This will be mirrored throughout the Apache network. There are a few remaining steps.
Now that a new version has been drafted on GitHub with source and pip packages published, we need to update the MXNet website. This process includes 2 steps, the first one is to create website artifacts in release version, the second is to update website in master branch.
Follow these steps to update website in release branch and create website artifacts.
Ensure all the above processes in step 3.2.1 are all completed. Next task is to update master version website.
RewriteRule in /docs/static_site/src/.htaccess under comment "# Set default website version to current stable". For example: update the version 1.x to the new release version: Can happen after the announcement.
Update the Table of Contents by deleting the one from the previous release, and generating a new one using the complete contents of news.md. You can use this markdown toc generator.
Also update NEWS.md and README.md on v1.x branch, If the release version is branched off from v1.x.
In order to get write access to blogs.apache.org/mxnet, one need to first register on blogs.apache.org and ask Henri (bayard@apache.org) to grant the permission.
Once everything is working (website docs, website changes, 24 hours after upload) create an announcement on the website and then send an email to the mailing list.
Follow instructions from here: http://www.apache.org/legal/release-policy.html#release-announcements
There must be a link in the announcement to the downloads page, not to the dyn/closer page. Downloads must be mirrored from the official Apache distribution site, not from github or other site. e.g. "A Link to the https://mxnet.apache.org/versions/1.8.0/get_started/download.html" |
Send an email to announce@apache.org, general@incubator.apache.org and dev@mxnet.incubator.apache.org with the subject: [ANNOUNCE] Release Apache MXNet (incubating) version $release and a body along the lines of:
The Apache MXNet (incubating) community is happy to announce Apache MXNet (incubating) version ##.#.#! ( ## if applicable ## ) Release blog post: ( ## -- if applicable -- ## ) Apache MXNet (incubating) is a deep learning framework designed for both efficiency and flexibility. It allows you to mix symbolic and imperative programming to maximize efficiency and productivity. ( ## for patch releases ## ) 1.3.1 is a maintenance release incorporating important bug fixes and important performance improvements. ( ## -- for patch releases -- ## ) A full list of the changes in this release can be found in the release notes: A link to the download page can be found here: If you prefer to build from source and experiment with various compile-time configuration options, use this link to get the instructions: Or you can download and play with MXNet easily using one of the options below: 1. The Pip packages can be found here: 2. The Docker Images can be found here:
The Pip package: The release tag: MXNet Resources - Our discussion forum (https://github.com/apache/incubator-mxnet/discussions) Social Media - Apache MXNet on Twitter (https://twitter.com/apachemxnet) For more information on Apache MXNet (incubating), please see:
_______ DISCLAIMER: Apache MXNet (incubating) is an effort undergoing incubation at The Apache Software Foundation (ASF), sponsored by the name of Apache Incubator PMC. Incubation is required of all newly accepted projects until a further review indicates that the infrastructure, communications, and decision making process have stabilized in a manner consistent with other successful ASF projects. While incubation status is not necessarily a reflection of the completeness or stability of the code, it does indicate that the project has yet to be fully endorsed by the ASF. https://cwiki.apache.org/confluence/x/BINjB |
Once the release is complete, make sure that all PRs that were created during the release process only for the release branch (version updates, README NEWS etc) are now merged into the master branch too.
Merge the PR you created for the release branch into the master
Add a new PR to bump up the version for next release
Clean up older releases stored in https://dist.apache.org/repos/dist/release/incubator/mxnet/ and https://dist.apache.org/repos/dist/dev/incubator/mxnet/
# checkout apache release repo svn co https://dist.apache.org/repos/dist/release/incubator/mxnet apache-mxnet-release cd apache-mxnet-release # remove the previous release folder svn rm 1.0.0 svn commit -m 'commit message' # checkout apache dev repo svn co https://dist.apache.org/repos/dist/dev/incubator/mxnet apache-mxnet-dev cd apache-mxnet-dev # remove the previous release candidate folders svn rm 1.1.0.rc* svn commit -m 'commit message' |
Enjoy an adult beverage (or bubble tea) of your choice, and congratulations on making a MXNet release.
For Every Release you must use the following checklist to ensure that all tasks happen in a timely manner -
In case you need to update this list, edit the original spreadsheet
| Task # | Task | Owner | Relative Date | Absolute Date |
| PreReqs for Release Start: | PM | |||
| 1 | Finalize the Release Date | PM | T-15 | |
| 2 | High Level List of Features and artifact specs | PM | T-15 | |
| 3 | Prepare Release Notes - draft 1 | PM | T-15 | |
| 4 | Inform the community | ReleaseLead | T-15 | |
| 5 | PR to update the Website into master/RB | WebsiteLead | T-14 | |
| 6 | PR to update the Docs into master/RB | DocsLead | T-14 | |
| 7 | PR to update the versions into master/RB | ReleaseLead | T-14 | |
| 8 | Validate License Headers and top Level LICENSE file | ReleaseLead | T-14 | |
| 9 | Validate/update submodules | ReleaseLead | T-14 | |
| 10 | Stabilize the code for CI to pass | ReleaseLead | T-14 | |
| 11 | Merge all necessary PRs into master | Community | T-13 | |
| 12 | Code Freeze and Release Start: Cut the Release Branch | ReleaseLead | T-10 | |
| 13 | Finalize the Release Notes based on PRs that got in - final draft | PM | T-10 | |
| 14 | PR to update the NEWS and README into the RB | ReleaseLead | T-9 | |
| 15 | Validate the docs build locally by checking release-specific docs like pip install, etc. | DocsLead | T-9 | |
| 16 | Test part 1: Run the unit Tests on the Release Branch | ReleaseLead | T-8 | |
| 17 | Test part 2: Run the Nightly Tests | ReleaseLead | T-8 | |
| 18 | Create the Github Tag for the rc0 | ReleaseLead | T-7 | |
| 19 | Create the src tar and sign, Upload the src tar | ReleaseLead | T-7 | |
| 20 | Validate the signatures | Release Lead | T-7 | |
| 21 | Clone svn repo and do a manual test | Release Lead | T-7 | |
| 22 | Update version number in Travis CI used for Scala Build | Release Lead | T-7 | |
| Begin Apache Voting | ReleaseLead | T-7 | ||
| 23 | Start the vote on dev@ | ReleaseLead | ||
| 24 | Send out the results of the vote on dev@ | ReleaseLead | T-4 | |
| 25 | Revote if necessary (Steps 15-22) | ReleaseLead | Not Accounted For | |
| 26 | Start the vote on general@ | ReleaseLead | T-4 | |
| 27 | Send out the results of the vote on general@ | ReleaseLead | T-1 | |
| End Apache Voting | ||||
| 28 | Create the final release tag on github | ReleaseLead | T-1 | |
| 29 | Rename, resign and upload the src tar to final dir | ReleaseLead | T-1 | |
| 30 | Update the website using tag | Website Lead | T-1 | |
| 31 | Release the official pip package | pip Lead | T-1 | |
| 32 | Release the official docker images | Docker Lead | T-1 | |
| 33 | After 24 hrs, validate the packages are uploaded | Release Lead | T | |
| 34 | Draft the offical announce email and review | Release Lead | T-1 | |
| 35 | Send out the email on announce@ | Release Lead | T | |
| 36 | Update the apache blog | Release Lead | T | |
| 37 | update the aws blog | PM | T | |
| 38 | send internal announcement | PM | T | |
| 39 | Update the version on master | Release Lead | T |
*NOTES FROM DOCS FOR REFERENCE:*
http://incubator.apache.org/guides/releasemanagement.html
- 3 +1 votes from IPMC members (these are the votes that count but we
should open up to the whole podling community)
- For podlings, 2 additional constraints:
- Release artifacts must include “incubating” in final file name (ex:
apache-mxnet-src-0.10.1-incubating.tar.gz)
- Release artifacts must include disclaimer in the release artifacts
- The Incubator PMC expects the source releases to be staged on
https://dist.apache.org/repos/dist/dev/incubator/podlingName so that
they can easily be moved to the release location via svn mv (
http://www.apache.org/dist/incubator/)
- After graduating, RC’s go into https://dist.apache.org/repos/dist/dev/
and official releases go into https://dist.apache.org/repos/dist/release/
http://incubator.apache.org/guides/branding.html#disclaimers
- Apache Press Team [http://www.apache.org/press/index.html#whoweare]
must review and coordinate releases for branding
- On website and in release DISCLAIMER file:
- Apache Podling-Name is an effort undergoing incubation at The Apache
Software Foundation (ASF), sponsored by the name of Apache TLP sponsor.
Incubation is required of all newly accepted projects until a further
review indicates that the infrastructure, communications, and decision
making process have stabilized in a manner consistent with other
successful
ASF projects. While incubation status is not necessarily a reflection of
the completeness or stability of the code, it does indicate that the
project has yet to be fully endorsed by the ASF.
- Website should include Apache Incubator logo:
http://incubator.apache.org/guides/press-kit.html
- Release should include:
- DISCLAIMER
- LICENSE
- NOTICE - attribution notices
http://www.apache.org/legal/release-policy.html
- A release must contain source package which is cryptographically
signed by Release lead with detached signature. It must be tested prior
to voting for release.
- Release must only contain appropriately licensed code
- Please ensure you wait >=24 hours after uploading a release before
making announcements so mirrors catch up
- Releases of more than 1GB of artifacts require a heads-up to
Infrastructure in advance.
- Which directory for what build?
http://www.apache.org/legal/release-policy.html#build-directories
http://www.apache.org/dev/release-distribution.html
- Artifacts MUST be accompanied by:
- apache-mxnet-src-0.10.1-incubating.asc - contains OpenPGP
compatible ASCII armored detached signature
- apache-mxnet-src-0.10.1-incubating.sha - SHA checksum (SHOULD)
- Publish KEYS file in distribution directory root
- Signing keys MUST be published in KEYS file, SHOULD be available in
global public keyserver
http://www.apache.org/dev/release-signing#keyserver, SHOULD be linked
into web of trust
- Keys MUST be RSA & 4096 bits
http://www.apache.org/dev/release-publishing.html
- Apache RAT can assist in checking license compliance
http://creadur.apache.org/rat/
- Eventually we should set up a build system to sign our releases with
cryptographic signatures. For now we’ll do it manually.
http://www.apache.org/dev/release-signing.html
- Create a signature and sign releases as mentioned above