You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 5 Next »

Design/Code Review Guidelines

Here is the general How-to write a Sqoop2 design proposal wiki

How-to design wiki

Use the above as a guideline to ask specific questions about the design such as the 

  • Scope of this feature
  • What the relevant components in Sqoop that will affected by this change

Code Reviews Should Check For:

  • Is the code change consistent with the proposed design?
  • Is the new feature or bug fix well covered by unit tests?
  • Is the new code sufficiently documented (i.e. code comments and wiki where needed) ? 
  • If the feature is user facing, the user documentation must be updated. 
  • Does the code break backward compatibility? (For example, adding abstract methods to class used by connectors)
  • Are there new dependencies? Are there new dependencies on non-open-source components?
  • Is the placement of objects in packages consistent with the rest of the project?
  • Does the patch apply? Unit and integration tests pass?

 

  • No labels