You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 2 Next »

This project uses Scala Steward to automatically create pull requests to update the project when new dependencies are released.

Required Checks

Before provding a +1 and merging pull requests created by Scala Steward, the following checks should be performed

  • Do all automated continuous integration checks pass?
  • Is the update a patch, minor, or major update?
    • Major updates need more stringent review criteria than the other updates, at least a manual reading of the library's release notes / changelog to check for API changes.
  • Is the license still compatible with ASF License Policy?
  • Have any changes been made to LICENSE/NOTICE files that need to be incorporated? 
    • Note that something as simple as a date change in a LICENSE/NOTICE file requires an update.

Making Updates

If changes are needed, such as updates to allow the integration tests to pass or to update a LICENSE/NOTICE file, the following steps can be performed:

  1. Add the Scala Steward daffodil fork as a new remote

    git remote add scala-steward git@github.com:scala-steward-org/daffodil.git

  2. Fetch the branch associated with the new depenency:

    git fetch scala-steward update/jackson-core-2.11.4

  3. Checkout the branch

    git checkout update/jackson-core-2.11.4
  4. Commit any necessary changes to this branch.
       

  5. Push changes back to the scala-steward remote

    git push scala-steward udpate/jackson-core-2.11.4
  6. Follow the Code Contributor Workflow just as usual, eventually squashing changes, and using push --force  to push those changes back to the scala-steward remote to update pull request before being merged.
  • No labels