Some 3rd party JS provided in app/assets/javascripts - sankey.js, vertical_sankey.js. Don't seem to be listed in DEPENDENCY_LICENCES.md. Do these need to be added to NOTICE? The sankey d3 plugin has a  custom licence but appears to be a do what you want as long as you provide the original licence

models/provenance.rb - Is this 3rd party or original databundle viewer code? Needs a licence header.

app/views/* all the .slim files need a licence header if possible. If headers can't be added do they go in NOTICE?

A lot of the files are originally autogenerated eg config/environment/* . Have these been changed since being generated? If so does that mean they need licence headers? If not do all the files that are autogenerated need added to NOTICE?

bower.json, package.json. Were these autogenerated? You can't add a header to a JSON file but they should be mentioned somewhere - NOTICE?

All the dependencies seem to be MIT or BSD so that seems OK.

  • No labels