1. builds/intermittent test failures
No additional flaky tests have been introduced by the feature branch.
2. documentation
3. design, attached the docs
The design docs can be found under the Attachments section in the umbrella jira:
4. Compatibility
The feature doesn't break compatibility for any of the existing features.
5. docker-compose / acceptance tests
TBD
6. support of containers / Kubernetes:
No addition so far. This would not be a merge blocker.
7. coverage/code quality:
Current feature branch coverage
8. build time
No significant build time difference has been observed.
master branch succeeded yesterday in 13m 30s:https://github.com/apache/ozone/actions/runs/3877624995/jobs/6612858610
Feature branch succeeded :
9. possible incompatible changes/used feature flag:
There should not be any incompatible changes introduced with this feature.
An enable/disable switch is not required. Snapshot feature has its independent se of CLIs that need not be exercised.
10. third party dependencies/licence changes:
NA
11. performance
The feature won't affect performance if the Snapshot feature is not in use. When snapshots are used, the performance can get impacted proportionate to the number of snapshots that are actively read from and the number of concurrent snapdiff operations,
12. security considerations
There should be no security implications when snapshot feature is not in use. Snapshots can be taken only by the owner of the bucket. Total number of snapshots in the system is limited by Ozone conf. Details of Snapshot feature authorization is discussed in the Snapshot model that is attached to public Jira