Review Board Guidelines

<DRAFT WORK IN PROGRESS>

We review code patches to ensure that submissions are relevant, good quality and following the coding guidelines and best practices.

Who should submit patches?

Contributors do not have commit privileges to the trunk and are required to submit patches through the review board.

Committers have commit privileges to the trunk but may choose to still submit the patches on review board if they want to solicit feedback from the community or specific persons.

How to submit a new patch?

Apache communities use Review Board Tool to manage code reviews. If you have not setup your account yet you will need to register first.

Review Board is used by most Apache Projects and shows reviews for all of these projects. Review Board uses the term "Groups" for the projects. If you are only interested in Apache CloudStack then you should update your preferences and select 'cloudstack' in Groups section on preferences page.

To submit a new patch:

1. Click on the New Review Request link.
2. Select "cloudstack-git" in the Repository dropdown, upload your diff and click "Create Review Request" to get to next page where you will enter more details in several fields
3. In "Groups" auto-fill text field specify "cloudstack"
4. In "People" auto-fill text field type in the name of persons who should be reviewing the patch. You can chose more than one person to review your patch. If you are not sure who should be reviewing your patch please check CloudStack Maintainers List By Components
5. In "Branch" text field specify the branches your patch should be submitted to.
6. If your patch fixes a defect specify the cloudstack jira bug id in "Bugs" text field.
7. In "Description" field add a brief description of what your patch does
8. In "Testing" field specify what tests were performed
9. Click "Publish" button to submit your patch