Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Additional improvements to JUnit 3->4 migration.

Remove JUnit3TestLegacyAssertclass. Replace Actualize JUnit3TestLegacyAssertclass: rename class, update documentation. Replacement inheritance to imports is not appropriate here as it leads to changes of all test classes.

Moreover, during migration to the next JUnit versions, problem with changing all test classes wil arrise again.

In JUnit3TestLegacySupport:

  1. Replace tearDown, setUp by @BeforeEach, @AfterEach annotations, beforeTest, afterTest methods where it is necessary
  2. The same situation with beforeTest, afterTest methods
  3. Replace beforeTestsStarted, afterTestsStopped by @BeforeAll, @AfterAll
  4. The rest methods move to GridAbstractTest.
  5. GridAbstractTest and GridCommonAbstractTest refactoring
  6. .
  7. Actualize JUnit3TestLegacySupport: remove deprecated annotation, rename class and specify documentation.
  8. Investigate replacement of beforeTest/afterTest and beforeTestsStarted/afterTestsStopped methods and if needed replace them by annotations - it is noticed in IGNITE-11413.

Futhermore, GridAbstractTest and GridCommonAbstractTest refactoring necessity should be investigated. Check ability to turn some instance

...

methods to static methods. It was mentioned in the conversation on dev-list.

Risks and Assumptions

  • Additional fails on TC because of migration issues
  • Performance degradation of tests execution.

...