Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: added minor changes based on feedback from Taher and Jacques

...

This is fairly small and doesn’t change the API signature. Examples include

...

2. Design Re-Factor (Complex)

    • This is a re-factor that impacts the design and incorporates changes to the current design.
    • This also includes changes to the API signatures that might affect existing applications
    • This could range from a small to a large re-factor of code.

 

A design re-factor is something significant so it would be good to share any proposal with the community for feedback and comments. Jira could be used and if there is a lot of concern regarding the change a branch could be created to verify the change before it is merged back

...

  • Taher went through a list of possible areas to start re-factoring. After some discussion it was decided that we will put together an initial batch of work to do that is publicly available so that people can assign themselves to a task. We need to ensure that people are comfortable picking up a task and assigning it so a mix of straightforward, easier tasks as well as harder more complex would be included.

  • We would look to implement the framework changes in the trunk and 15.12. The changes would not be back ported to any of the live release branches. This means that anyone using the current releases would not be affected by the framework changes. (Jacopo suggested that because of the framework changes it might be a bit harder to upgrade so we could possibly consider extending the life of the release branches to compensate.)

  • Jacopo mentioned that changing the framework code that is not exposed to the applications is fairly easy so this would be a good place to start.

  • Jacopo also suggested that during the re-factoring process if people have performed a change but see many places where a similar change is needed, then it would be good to publish the template showing how the problem was fixed. This would help other people to fix problems in other areas by using the template and adjusting it.
  • We briefly discussed the need for better test coverage and it was suggested that if people are not comfortable doing code changes then they can also help with improving the tests.

    Info
    NOTE: Jacques wants to remind people about
    Jira
    serverASF JIRA
    serverId5aa69414-a9e9-3523-82ec-879b028fb15b
    keyOFBIZ-4757
  • Jacopo suggested we could "freeze" the framework part of the trunk and do the refactoring of the framework in a branch and merge it back to the trunk after a few weeks (no long waiting impractical branches). And in the process also upgrade the applications to it. This way it lets the people playing with framework refactoring to do the changes without the workload of upgrading the applications after every commit. And instead upgrade all the applications after a set of framework changes are done and "stable". In the process it's highly recommended to document the changes in the commit/s of course. But also in related JIRA issue/s and possibly in the Wiki for main/important changes.

...