Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.


IDIEP-30
Author
Sponsor
Created 21.02.2018
Status

Status
colourGrey
titleDRAFT



Table of Contents

Motivation

...

The community is informed about the migration to 5 and benefits of the newest version.

Additional improvements

...

in JUnit 3->4 migration.

Remove JUnit3TestLegacyAssertclass. Replace inheritance to importsActualize JUnit3TestLegacyAssert class: rename it, update documentation. Replacement inheritance to imports is not appropriate here as it leads to changes of all test classes. Moreover, during migration to the next JUnit versions, problem with changing all test classes will arrise again and in new test classes developer should make import manually.

In JUnit3TestLegacySupport:

  1. Investigate replacement of beforeTest/afterTest and beforeTestsStarted/afterTestsStopped methods and if needed replace them by annotations - it is noticed in IGNITE-11413.
  2. Replace tearDown, setUp by @BeforeEach, @AfterEach annotations, beforeTest, afterTest methods where it is necessary
  3. The same situation with beforeTest, afterTest methods
  4. Replace beforeTestsStarted, afterTestsStopped by @BeforeAll, @AfterAll
  5. The rest methods move to GridAbstractTest.
  6. .
  7. Actualize JUnit3TestLegacySupport: remove deprecated annotation, rename class and specify documentation.

Futhermore, GridAbstractTest and GridCommonAbstractTest refactoring necessity should be investigated. Check ability to turn some instance

...

methods to static methods. It was mentioned in the conversation on dev-list.

Risks and Assumptions

  • Additional fails on TC because of migration issues
  • Performance degradation of tests execution.

...