Page History

...

UI Mockups: 


Implementation:

Step 1: List Providers

ListOAuthProvidersCmd gets called when the user hits the login page. It's sessionless, so it implements APIAuthenticator — ; the authenticate() hook lets it run without a session. It lists OAuth providers (global and domain-based), with oauth2.enabled checked per-domain to set the enabled flag on each provider.

...

User clicks the provider button. Browser redirects to GitHub with the client_id. GitHub authenticates the user and redirects back with a one-time auth code. The secret_key never leaves the backend.

Browser                            GitHub
  │                                   │
  │   GET /login/oauth/authorize       │
  │   ?client_id=Ov23liDRnt6bVJ       │
  │   &scope=user:email                │
  │──────────────────────────────────→│
  │                                   │
  │            User logs in, clicks "Allow"	  |
  │                                   │
  │   302 Redirect to:                │
  │   verifyOauth?code=AUTH_CODE      │
  │←──────────────────────────────────│
  ▼
VerifyOauth.vue catches ?code=AUTH_CODE

Step 3: Verify Code and Fetch Email

UI calls verifyOAuthCodeAndGetUser with the auth code, provider, and domain. VerifyOAuthCodeAndGetUserCmd resolves the domain via resolveDomainId(), then passes it to _oauth2mgr.verifyCodeAndFetchEmail() — which looks up that domain's OAuth credentials from the DB, exchanges the auth code for an access token at GitHub's token endpoint, fetches the user's email, and returns it to the UI.

...

UI calls oauthlogin with the email, provider, auth code, and domain. OauthLoginAPIAuthenticatorCmd resolves the domain, checks oauth2.enabled for it, finds the CloudStack user by email, then calls loginUser(). On success, records OauthLogin=true and returns a session key. oauth2.enabled is checked in both Step 1 (hides buttons if disabled) and Step 4 (backend safety net against direct API calls).

OauthLoginAPIAuthenticatorCmd.authenticate()
  │
  ├── resolves domain
  ├── checks oauth2.enabled for domain
  ├── finds user by email
  │
  ├── _apiServer.loginUser(username, password=null, domainId)
  │         │
  │         ▼
  │   OAuth2UserAuthenticator.authenticate()
  │   ├── checks oauth2.enabled for domain (again)
  │   ├── calls GithubOAuth2Provider.verifyUser(email, code, domainId)
  │   │   ├── looks up domain credentials from DB
  │   │   ├── exchanges code with GitHub
  │   │   └── compares emails
  │   └── returns true → login succeeds
  │
  ├── records OauthLogin=true
  └── returns session key → UI redirects to dashboard

How loginUser() triggers GitHub verification: loginUser() doesn't know about OAuth — ; it delegates to accountMgr.authenticateUser(), which loops through all registered UserAuthenticator implementations. OAuth2UserAuthenticator sees provider=github and and secretcode in the request params, picks it up, looks up GithubOAuth2Provider from the manager's map, and calls verifyUser(email, secretCode, domainId). The original HTTP request params flow through the entire chain as the thread connecting everything.

OauthLoginAPIAuthenticatorCmd.authenticate()
  → _apiServer.loginUser()                    [ApiServer.java:1243]
    → accountMgr.authenticateUser()           [AccountManagerImpl.java:2850]
      → for (authenticator : _userAuthenticators) [line 2939]
        → OAuth2UserAuthenticator.authenticate()  [OAuth2UserAuthenticator.java:48]
          → GithubOAuth2Provider.verifyUser()     [GithubOAuth2Provider.java:70]

Step 5: Login Page (External Tab) Behavior

• On page load, the UI calls listOauthProvider without a domain parameter
• External tab is enabled if response.listoauthproviderresponse.count > 0
• Global provider buttons (Google/GitHub) are rendered from the returned list
• If no global providers exist but domain providers do, the tab is enabled with the message: "Enter your domain to see available providers"
• When the user enters a domain path in the domain field, the UI calls listOauthProvider with domain=<path>
• Domain-specific provider buttons are rendered, or "No OAuth providers configured for this domain" is shown
  
  

Other Changes

Admin commands — how providers get registered/updated/deleted

...

DB migration — schema changes (domain_id column, FK, unique key)

Config change — oauth2.enabled scope from Global to Domain

GitHub/Google provider internals — DAO lookup changed from findByProvider() to findByProviderAndDomainWithGlobalFallback()

API Changes:

registerOAuthProvider

...

• domain_id = NULL indicates a global provider
• Unique constraint on (provider, domain_id) prevents duplicate registrations

Strict Scope for oauth2.enabled

The oauth2.enabled config key uses a new strictScope mode in ConfigKey.valueInScope() to prevent automatic inheritance from global to domain scope. Each domain must explicitly set oauth2.enabled=true to enable OAuth login.

Key difference from standard ConfigKey behavior: without strict scope, an unconfigured domain inherits the global value. With strict scope, unconfigured domains return null which is treated as disabled. This ensures domains must explicitly opt in to OAuth.

Implementation Details

• New overload: ConfigKey.valueInScope(Scope scope, Long id, boolean strictScope)
• Existing valueInScope(Scope, Long) delegates to new overload with strictScope=false for backward compatibility
• When strictScope=true and no scope-specific value exists, returns null instead of walking up the parent scope hierarchy
• All OAuth oauth2.enabled checks use: Boolean.TRUE.equals(OAuth2IsPluginEnabled.valueInScope(ConfigKey.Scope.Domain, domainId, true))