Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.
Comment: When to close a Jira issue

...

Info
titleRepositoy structure

After the svn tag "beforeSvnRestructuring" the repository structure has changed, please refer to history for information before this tag

 


Table of Contents

The committers of OFBiz are a core group of developers who have the ability to commit changes into the OFBiz source code repository. As the project has grown over the years, there have been more committers of projects, so we thought it would be a good idea to define what the roles and responsibilities of the committers are. These points below are based on discussions we recently had on the developers' list:

...

Warning
titleNo patches when moving files

Patches should never be used to move files. The diff and patch commands (even "svn di" and "svn patch") are unable to keep the information about moved files, only deleted and created.

So we must not apply patches with files relocations. We not only lose history when doing so, but also annotations

...


All committers must do the following to ensure licensing compliance

...

  1. Only bugfixes should be backported to active release branches (if they happen also there).
  2. Bugfixes should be backported by the committer who did the bugfix in trunk, if possible.
  3. If the committer does not, for an reason, backport the bugfix, he should leave the original issue open with a remark that a backport is needed and a short explanation why he does not do the backport.
  4. Issues which need a back port should be labelled as "back port-needed". In this way we are able to spot issues to be backported, especially before a release is on it's way. 
  5. In no case should the Jira issue be closed without doing 1. or 2.
  6. When you backport something, if you know that it should not be backported in older releases, please pass the information.

...


Christian Carlow asked

Should committers download the entire ofbiz repository to help with backporting?

...

ofbiz/
ofbiz/trunk
ofbiz/release14.12
ofbiz/release13.07
ofbiz/release12.04
ofbiz/site

...


Is there a standard procedure new committers should follow for backporting?

...


Here is a simple workflow to backport a commit to a branch. 

...

  • Upcoming Branch (only for commits only done to trunk, ie when not backporting)

As per our conventions, when the reporter or the assignee, or even another person who has reviewed, decides the issue is implemented, done or fixed the issue should be CLOSED.

After some time the following Jira reports will contain very useful information :

...

The ASF has a Code of conduct, it's good to know and remember it. Though for miscellaneous reason you become a committer for life, please note this:  "When somebody leaves or disengages from the project they should tell people they are leaving and take the proper steps to ensure that others can pick up where they left off."