Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

Rule #1 for a committer is the same as for a doctor: first do no harm. Nothing should be committed that breaks existing functionality just to make something easier for a particular client or customization effort. This means, in particular, that if some progress is made on a certain effort but you can't finish it in the time you have available, then don't commit it if it breaks anything that was there, just keep it local or attach it to a Jira issue or something if you want others to be able to get involved (or just it to the point where the stuff it broke works again, then commit it).

Rule #2 for a committer is the same as for a scientist: read before you write. When you're getting started a good time ratio for reading to write is around 20 to 1. Once you're a total OFBiz pro who knows as much as any living person about the project, you can probably reduce that to about 3 to 1.

To avoid code ownership, anyone can work on anything, but please be sensitive to areas where you are not familiar with the code and check with others who have worked in the area before doing something. A good practice is to ask someone who is more familiar with something to review it before you commit it, and if they have objections respect it and find a compromise that works for everyone.

...