You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 6 Next »

Status

Current state: Under Discussion

Discussion thread: TBD

JIRA: here [Change the link from KAFKA-1 to your own ticket]

Please keep the discussion on the mailing list rather than commenting on the wiki (wiki discussions get unwieldy fast).

Motivation

Under static membership, client user could provide a list of hard-coded `group.instance.id` so that the server could respond to scaling operations more intelligently. For example when we scale up the fleet by defining 4 new client instance ids, the server shall wait until all 4 new members to join the group before kicking out the rebalance, same with scale down. This change requires us to change JoinGroup protocol to batch mode in order to enable admin request to easily scale.

Proposed Changes

Adding protocol level support for batch join.

Add admin request to utilize this feature.

Public Interfaces

We will bump JoinGroup request/response version to support batch adding members.

JoinGroupRequest => GroupId SessionTimeout RebalanceTimeout MemberId GroupInstanceId ProtocolType GroupProtocols
  GroupId             => String
  SessionTimeout      => int32  // removed
  RebalanceTimeout    => int32  // removed
  MemberId            => String // removed
  GroupInstanceId     => String // removed
  ProtocolType        => String 
  GroupProtocols      => [Protocol MemberMetadata]
  Protocol            => String // removed
  MemberMetadata      => bytes // removed
  JoinGroupMembers    => []JoinGroupRequestMember // new
						   SessionTimeout      => int32  // new
						   RebalanceTimeout    => int32  // new
 						   MemberId            => String // new
						   GroupInstanceId     => String // new
						   Protocol            => String // new

JoinGroupResponse => ThrottleTime ErrorCode GenerationId ProtocolName LeaderId MemberId Members
  ThrottleTime           => int16
  ErrorCode              => int16  // removed
  GenerationId           => int32
  ProtocolName           => String
  LeaderId               => String
  MemberId               => String // removed
  Members                => []JoinGroupResponseMember 	
							  MemberId         => String
                              GroupInstanceId  => String
                              Metadata         => bytes
  MemberJoinResponseList => []JoinGroupResult  // new
							  MemberInfo 	=> JoinGroupResponseMember	
							  ErrorCode   => int16

A new admin request shall be created to execute this request by supplying a list of `group.instance.id`:

AdminClient.java
public static AddMemberResult addMembersToGroup(String groupId, list<String> groupInstanceIdsToAdd, AddMemberToGroupOptions options);


In the meantime, for better visibility for static members, we are also going to bump DescribeGroup request/response protocol to include `group.instance.id`:

DescribeGroupRequest => ThrottleTime Groups
  ThrottleTime           => int16
  Groups                 => []DescribeGroups
							  ErrorCode        => int16
							  GroupId          => String
							  GroupState       => String
							  ProtocolType     => String
							  ProtocolData     => int16
							  Members          => []DescribedGroupMember
									    			MemberId   => String
										    		GroupInstanceId  => String // new
											    	ClientId         => String							
										    		ClientHost       => String
											    	MemberMetadata   => bytes
    												MemberAssignment => bytes

Compatibility, Deprecation, and Migration Plan

  • User needs to upgrade broker to be able to use this new feature. Since we are introducing a new admin API, the change should be backward compatible.

Rejected Alternatives

We could trigger multiple join group requests at the same time without changing JoinGroup protocol. However, considering our change in LeaveGroupRequest, it's hard to handle multiple responses within single admin client request. Changing the protocol to adapt to this change shall be more consistent.

  • No labels