Status

Current state: Under discussion

Discussion thread: here [Change the link from the KIP proposal email archive to your own email thread]

JIRA: KAFKA-7689

Please keep the discussion on the mailing list rather than commenting on the wiki (wiki discussions get unwieldy fast).

Motivation

Resetting the offsets of a consumer group is a relatively common operation. It's usually done to allow an application to reprocess data or otherwise to skip/drop records. Currently (thanks to KIP-122) it can be done using the kafka-consumer-group.sh tool however it would be nice to be able to to it directly with the AdminClient. Applications can more easily depend on the AdminClient API rather than running the ConsumerGroupsCommand class or worse reimplementing the logic. This justifies integrating the consumer group reset functionality directly in the AdminClient.

Public Interfaces

Plan is to add 4 new methods to the AdminClient public API:

    /**
     * <p>Commits offsets for the specified group.
     *
     * <p>This is a convenience method for {@link #commitConsumerGroupOffsets(String, Map, CommitOffsetsOptions)} with default options.
     * See the overload for more details.
     *
     * @param groupId The group for which to commit offsets.
     * @param offsets A map of offsets by partition with associated metadata.
     * @return The CommitOffsetsResult.
     */
    public CommitOffsetsResult commitConsumerGroupOffsets(String groupId, Map<TopicPartition, OffsetAndMetadata> offsets) {
        return commitOffsets(groupId, offsets, new CommitOffsetsOptions());
    }

    /**
     * <p>Commits offsets for the specified group.
     *
     * <p>This operation is not transactional so it may succeed for some partition while fail for others.
     *
     * @param groupId The group for which to commit offsets.
     * @param offsets A map of offsets by partition with associated metadata.
     * @param options The options to use when committing the offsets.
     * @return The CommitOffsetsResult.
     */
    public abstract CommitOffsetsResult commitConsumerGroupOffsets(String groupId, Map<TopicPartition, OffsetAndMetadata> offsets, CommitOffsetsOptions options);

    /**
     * <p>List offset for the specified partitions.
     *
     * <p>This is a convenience method for {@link #listOffsets(Collection, ListOffsetsOptions)} which returns the
     * latest uncommitted offsets.
     *
     * @param topicPartitionOffsets The mapping from partition to the timestamp to look up.
     * @return The ListOffsetsResult.
     */
    public ListOffsetsResult listOffsets(Map<TopicPartition, Long> topicPartitionOffsets) {
        return listOffsets(topicPartitionOffsets, ListOffsetsOptions.latestUncommitted());
    }


    /**
     * <p>List offset for the specified partitions.
     *
     * @param topicPartitionOffsets The mapping from partition to the timestamp to look up.
     * @param options The options to use when retrieving the offsets
     * @return The ListOffsetsResult.
     */
    public abstract ListOffsetsResult listOffsets(Map<TopicPartition, Long> topicPartitionOffsets, ListOffsetsOptions options);

We will also add companion objects under org.apache.kafka.clients.admin for these methods:

• CommitOffsetsResult:

/**
 * The result of the {@link AdminClient#commitOffsets(String, Map)} call.
 *
 * The API of this class is evolving, see {@link AdminClient} for details.
 */
@InterfaceStability.Evolving
public class CommitOffsetsResult {

    public CommitOffsetsResult(Map<TopicPartition, KafkaFuture<Void>> futures) {}

    public Map<TopicPartition, KafkaFuture<Void>> values() {}

    public KafkaFuture<Void> all() {}
}

• CommitOffsetsOptions
  

  
  

  CommitOffsetsOptions.java

  /**
   * Options for the {@link AdminClient#commitOffsets(String, org.apache.kafka.clients.consumer.OffsetAndMetadata, CommitOffsetsOptions) call.
   *
   * The API of this class is evolving, see {@link AdminClient} for details.
   */
  @InterfaceStability.Evolving
  public class CommitOffsetsOptions extends AbstractOptions<CommitOffsetsOptions> {
  }

• ListOffsetsResult
  

  
  

  ListOffsetsResult.java

  /**
   * The result of the {@link AdminClient#listOffsets(String)} call.
   *
   * The API of this class is evolving, see {@link AdminClient} for details.
   */
  @InterfaceStability.Evolving
  public class ListOffsetsResult {
  
      public ListOffsetsResult(Map<TopicPartition, KafkaFuture<ListOffsetsResultInfo>> futures) {}
  
      /**
       * Return a map from TopicPartition to futures which can be used to retrieve the offsets
       */
      public Map<TopicPartition, KafkaFuture<ListOffsetsResultInfo>> values() {}
  
      /**
       * Return a future which succeeds only if offsets for all specified partitions have been successfully
       * retrieved.
       */
      public KafkaFuture<Map<TopicPartition, ListOffsetsResultInfo>> all() {}
  
      static public class ListOffsetsResultInfo {
  
          ListOffsetsResultInfo(long offset, long timestamp) {}
  
          long offset() {}
          long timestamp() {}
      }
  }

• ListOffsetsOptions
  

  
  

  ListOffsetsOptions.java

  /**
   * Options for {@link AdminClient#listOffsets()}.
   *
   * The API of this class is evolving, see {@link AdminClient} for details.
   */
  @InterfaceStability.Evolving
  public class ListOffsetsOptions extends AbstractOptions<ListOffsetsOptions> {
  
      private final String isolationLevel;
  
      public ListOffsetsOptions(String isolationLevel) {}
  
      public String isolationLevel() {}
  }

Proposed Changes

The proposal of this KIP is to add methods to commit offsets for a group in the AdminClient. Alongside, methods to retrieve log offsets (ListOffset API) so users can easily retrieve start and end offsets or offsets for a timestamp for partitions will be added.

The 4 new methods in AdminClient:

• public CommitOffsetsResult commitConsumerGroupOffsets(String groupId, Map<TopicPartition, OffsetAndMetadata> offsets) {}
• public abstract CommitOffsetsResult commitConsumerGroupOffsets(String groupId, Map<TopicPartition, OffsetAndMetadata> offsets, CommitOffsetsOptions options);
• public ListOffsetsResult listOffsets(Map<TopicPartition, Long> topicPartitionOffsets) {}
• public abstract ListOffsetsResult listOffsets(Map<TopicPartition, Long> topicPartitionOffsets, ListOffsetsOptions options);

Regarding the implementation, instead of relying on KafkaConsumer to perform the commit, I propose to instead directly send OffsetCommit requests. This is principaly for 2 reasons

• Be more performant. In order to commit offsets, a KafkaConsumer has to be created for each group. It first needs to subscribe or be assigned topic/partitions before being able to commit offsets. Additionaly we've need to pause consumption so calls to poll to perform the commit operation don't return records. That would require more connections/disconnections to the cluster, more network requests.
• Avoid having the AdminClient depend on KafkaConsumer. Currently AdminClient does not depend on another client.

Compatibility, Deprecation, and Migration Plan

No impact or migration plan required as this proposal is only adding new methods and not changing any current behaviour.

Rejected Alternatives

• Implement offset reset like it is currently done in ConsumerGroupCommand. As mentioned in the motivation section, this is inefficient.