Multiple Ip ranges FS

Introduction:

Currently in cloudstack we can add multiple public IP ranges in Advanced zone. we want to provide similar flexibility for management and guest IP ranges.
Presently we can add multiple guest IP ranges within the same subnet in Basic Zone but we cannot add IP ranges form different subnets.

This feature provides this functionality for adding guest IP ranges in Basic zone and management IP range for both the advanced and basic zones.

Use case:

There may be cases where admin may want to add more IP address once the old ones are exhausted. Admin may want to add the IP ranges form the same subnet or from different one. Currently in cloudstack there is no flexibility to do this for management Ips and guest IP ranges.

Design description:

Addition of guest IPs in Basic zone.

presently the createVlanIpRange API is used to add the guest IP range to a network (shared) in basic zone. The IPs mentioned in this range are assigned to the guest VMs. These are public IPs and allow guest to communicate with the internet. Presently we can add multiple ranges form the same subnet but not from a different one. This feature will extend the createVlanIpRange to add guest IPs from a different subnet, to a shared network in basic zone.

APIs:

for description of existing parameters please refer this page. http://incubator.apache.org/cloudstack/docs/api/apidocs-4.0.0/root_admin/createVlanIpRange.html

Validation.
#1 Will fail if the zone is not a basic zone or if forvirtual network is true.
#2 if the IP is from a different subnet, netmask and gateway should be provided.

Implementation detail.
In cases where a IP range form a different subnet is added, we need to configure an nic with a IP form the this new subnet or add this IP to the existing nic. This is required as the IP to the guest VMs is allocated using a DHCP server. So the router should have a interface on the new subnet to listen for the DHCP request coming form VMs in the new subnet.

execution flow.
#1 validate the inputs.
#2 Add the new range to the DB.
#3 When the first ip from the new subnet is allocated to the VM, create a new virtual interface to the existing nic on the VR. This virtual interface (example eth0:1) will have one of the IPs from the new subnet.

Note. The admin should manually configure the gateway of the new subnet before adding the IP range.

Addition of Management (pod) Ips in both Advance and Basic zone.

Currently there is no way to add additional pod IP ranges. This feature will enable adding pod IP ranges from same subnet or different subnet. The pod IP ranges (private Ips) are assigned to router vms and systemvms. The IP configuration is passed in as boot args. So in this case we need not configure the DHCP server.

API

Description of parameters.

(remove is the new parameter that we are going to add.)

validation.
#1 We use checkpodAttributes function in configurationManagerImpl.

execution flow.
#1 validate the input.(This will be done using the checkpodAttributes function of the configureationManagerImpl).
#3 Add the new range.

removing the the guest IPs from the Basic zone.

we intend to use the deleteVlanRange API to delete the IP ranges. The operations will be atomic. this will fail if any IP form the remove range is being used. While removing we acquire a lock on the valn that is being removed. When the subnet is removed the ip alias corresponding to this subnet will be removed form the VR.

Removing of Management (pod) IPs for Advanced and Basic Zone.

The Pod IPs can be removed only when they are not in use. We intend to do this by modifying update pod API.
Currently the update pod api can be used to change the gateway, netmask and private IP range of a pod. We will extend this api to support removal of a particular private IP range or an entire subnet. The update pod API will make atomic changes (all or nothing )ie if the remove IP range contains any IPs that are in use the update api will throw an error and will not succeed partially.

We do this by setting the remove parameter of the Updatepod API to true.
example
Existing: 10.147.28.20 to 10.147.28.147.40 used: 10.147.28.22
Remove: 10.10.147.28.20 to 10.147.28.147.40
this will fail as 10.147.28.22 is in use.

DB changes:

No Database changes are required.

Supported Hypervisors.

KVM, XenServer, VMware

Note: we can add or remove only one IP range at a time for now.