You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 22 Next »

Status

Current state: Under Discussion

Discussion thread: here

Vote thread: here

JIRA: KAFKA-16936 - Getting issue details... STATUS

Motivation

More discussions: https://github.com/apache/kafka/pull/16260#issuecomment-2159632052

The logging library used in the tools module is inconsistent with the core. Now, slf4j2.x provides a cleaner and more straightforward approach.

By adding slf4j backends to dependencies, distributions will have their slf4j backends, and it is safe to define a slf4j provider in kafka-run-class. This also allows running a Kafka instance from the source code with a specific provider.

More importantly, this change will bring 2 benefits:

  • Specifying the provider class explicitly via the slf4j.provider  system property bypasses the service loader mechanism for finding providers and may shorten SLF4J initialization. ( reference : https://www.slf4j.org/faq.html#explicitProvider)
  • Indirectly controlling the logging frameworks that Kafka supports by explicitly declaring supported SLF4J providers. This approach would require users to identify and implement logging frameworks that are compatible with our declared providers. By implementing this strategy, we can substantially reduce our maintenance overhead while ensuring consistent logging behavior across implementations.

Public Interfaces

Update the below to upgrade slf4j, starting with the 4.1.0 version.

  • dependencies.gradle 
  • build.gradle 

Proposed Changes

  1. Upgrade slf4j from 1.7.36 to 2.0.17
  2. Add a new system variable to the kafka-run-class  (sh & bat) script to define -Dslf4j.provider.
  3. Add other popular slf4j backend binding provider dependencies, e.g., logback 

Compatibility, Deprecation, and Migration Plan

Ensure the user's code works well when specifying their preferred logging frameworks.

We will provide compatible binding jars for log4j2 in Kafka when slf4j-api  upgrading to 2.0.17

As we introduce this change in major version 4.1.0, since we provide the backend binding dependencies, users should be able to upgrade their backend dependencies. 

Please note that users have to upgrade their logging framework to the matched provider explicitly, and we expect users to be responsible for keeping a consistent version when using other providers.

For future slf4j upgrade: In the future, for slf4j upgrades, we agree not to have a KIP again and follow the same approach mentioned in this KIP.

Test Plan

Imitate the user's behavior by manually adding or replacing the dependent logging jars and assigning the corresponding system property by -Dslf4j.provider .
After that, try starting a Kafka service and see if there are any warnings or errors. Make sure Kafka still usually works after changing the logging framework.

Rejected Alternatives

N/A

  • No labels