Review Board

This is a quick tutorial on using Review Board with Kafka.

1. Install the post-review tool

Follow the instructions here to setup the post-review tool.

2. Configure Stuff

Then you need to configure a few things to make it work:

First set the review board url to use. You can do this from in git:

git config reviewboard.url https://reviews.apache.org

If you checked out using the git wip http url that confusingly won't work with review board. So you need to configure an override to use the non-http url. You can do this by adding a config file like this:

jkreps$ cat ~/.reviewboardrc
REPOSITORY = 'git://git.apache.org/kafka.git'

3. Post Patches

Now to file a new review board containing the differences in this branch versus trunk do

jkreps$ post-review --tracking-branch=origin/trunk
==> HTTP Authentication Required
Enter authorization information for "Web API" at reviews.apache.org
Username: jkreps
Password:
Review request #13834 posted.

https://reviews.apache.org/r/13834/

You can also fill in some of the fields as part of your command by doing

jkreps$ post-review --tracking-branch=origin/trunk --summary="My simple change" --description="A simple change that I made"

Or if you are lazy and there is only one commit you can have review board guess the summary and description from the commit message:

jkreps$ post-review --tracking-branch=origin/trunk -g

4. Revise Your Patches

You can update an existing review board by using the -r option to specify which review board to update:

jkreps$ post-review --tracking-branch=origin/trunk -r 42