You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 3 Next »

Status

Current state: “Under Discussion”

Discussion thread: https://lists.apache.org/thread/sb2jrrl9f5vn26mfmwf9qo7w2rkcryfj

JIRA: https://issues.apache.org/jira/browse/SOLR-17458?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17941031#comment-17941031

Released: 10

Motivation

Solr currently uses the Java Dropwizard 4 library for metric collection and event measurement. While Dropwizard is reliable, its primary limitation is the lack of support for tag-based or attribute-based metrics. This constraint reduces metric granularity because metrics are static, with tags embedded directly into metric names. To get around this Solr includes a Prometheus exporter that aggregates Dropwizard metrics into Prometheus using the /metrics api to scrape the metrics in prometheus format giving more dimensionality and easier aggregation with PromQL. However, this running an exporter introduces extra operational overhead and can be costly to maintain externally.

Furthermore, Solr faces vendor lock-in with Dropwizard. Transitioning toward an observability framework that inherently supports dynamic tags and attributes such as OpenTelemetry future-proof Solr against changing observability requirements.

Public Interfaces

The Open Telemetry Module or with the inclusion of SOLR-17432 Java Agent, takes the Open Telemetry API that is currently used for traces and embeds a OTLP exporter. can be used to export trace and now additional metrics. Users just need to set the following system property:

otel.metrics.exporter=otlp


With the Open Telemetry module or Java Agent, users can also connect with an OTel collector to export metrics to their chosen observability tool/vendor of their choice. An example of the OTel Collector config is shown below that will pull in OTLP and export into Prometheus on port `8889`.

service:
  # extensions: [health_check, pprof, zpages]
  pipelines:
	metrics:
	receivers: [otlp]
    exporters: [prometheus]
  telemetry:
	metrics:
    address: 0.0.0.0:8888
    level: detailed

receivers:
  # Data sources: traces, metrics, logs
  otlp:
	protocols:
    	grpc:
	     endpoint: 0.0.0.0:4317
    	http:
	     endpoint: 0.0.0.0:4318

exporters:
  prometheus:
	endpoint: 0.0.0.0:8889
	namespace: default


Users can also user prometheus OTLP receiver as seen here https://prometheus.io/docs/guides/opentelemetry/ if they don’t want to use OTEL collector but this makes the prometheus server use a push mechanism.

The GET /admin/metrics API can change in a few ways. One way is outputting metrics in Prometheus format, the same as what `GET /admin/metrics?wt=prometheus` currently supports. This allows users to still use Prometheus servers or tools to pull and scrape solr nodes for metrics. This API will retain its filtering capabilities, allowing users to selectively expose the metrics they need. Other option is to bridge OTEL metrics into some form of JSON but will not necessarily look equivalent to dropwizard.

With this change, the Prometheus exporter will be deprecated unless repurposed for other uses. This will reduce maintenance of the project of no longer needing to support it. Users will be directed to alternative solutions such as the OTEL collector for transferring metrics to their preferred monitoring systems or vendors. For those requiring pre-aggregation filtering or custom solutions, tools like Telegraf can be recommended.

Potentially include OpenTelemetry Prometheus Exporter, enabling an embedded Prometheus server to bind to a separate port and expose Prometheus metrics for scraping. This can be set with the following system properties or environment variables in Solr:

otel.metrics.exporter=prometheus
otel.exporter.prometheus.port=9464
otel.exporter.prometheus.host=0.0.0.0

Proposed Changes

OpenTelemetry module or OTEL Java Agent

We aim to leverage the Solr Open Telemetry module or the OTel Java agent with the introduction of SOLR-17432, which initializes the Open Telemetry SDK for traces, to also push OTel metrics via OTLP. Metrics is currently hard coded to be off in the OTel module and we will remove this for metrics. We will collect metrics with the Open Telemetry API and this transition will completely remove Dropwizard, enabling support for an attribute-based metric system.

Open Telemetry supports different types of instruments which we will try to migrate from Dropwizards equivalent. See Open Telemetry Meter section from its documentation.

SolrMetricsContext needs to be completely refactored instead of being wrapped around Dropwizard to being wrapped around Open Telemetry. Some custom metric types that Solr uses from Dropwizard might not be possible or too difficult to port over to OTel such as MetricsMaps or complex Gauges.

The concept of registries goes away and metrics and meters will be retrieved from a GlobalOpenTelemetry object to measure events.

Metrics API (GET /admin/metrics)

The GET /admin/metrics API will continue to exist, allowing users to scrape metrics. However, the removal of Dropwizard means the current format will change. We have several options:

  1. Replace API with Prometheus Formatted Metrics:
    • The metrics API by default will expose Prometheus formatted metrics instead
    • Leverage the Open Telemetry to prometheus bridge to go from OTEL -> Prometheus and use the Prometheus Response Writer.
    • Deprecate all internal Prometheus Formatter code as we are no longer going from Dropwizard -> Prometheus 
    • Deprecate or repurpose the Prometheus Exporter.
  2. Create a Bridge/Shim for OTEL -> Dropwizard format:
    • Export OTel metrics to Dropwizard JSON format to maintain backward compatibility with a custom bridge.
    • Prometheus Exporter can continue to exist for custom configurations

Filtering

We will maintain filtering capabilities on the metrics API to enable users to limit the amount of data and metrics being scraped from the endpoint. Enhancements may include filtering by tags, preserving the concept of registries/groups with Open Telemetry, or specific metric names possibly. Need to see what the Open Telemetry SDK supports for filtering in Solr but also filtering is possible to happen at an exporter level with OTEL collectorl

Deprecation of Prometheus Exporter

With the removal and deprecation of the Prometheus Exporter, users will be encouraged to adopt alternative solutions such as the OTel collector. For those requiring pre-aggregation filtering or custom solutions, tools like Telegraf can be recommended. Deprecating this also is a benefit of no longer needing to maintain this.

JVM Metrics Collection

JVM metrics can be collected using the Open Telemetry runtime-telemetry-java17, which gathers comprehensive metric sets from JFR and JMX. We can also programmatically filter what metrics we want based JfrFeatures available giving further filtering for users. See the runtime-telemetry-java17 JfrFeature table.

Snippet of these metrics output from OTel:

jvm_gc_duration_seconds_count{jvm_gc_action="end of minor GC",jvm_gc_name="G1 Young Generation",otel_scope_name="io.opentelemetry.runtime-telemetry-java17",otel_scope_version="2.14.0-alpha"} 3
jvm_gc_duration_seconds_sum{jvm_gc_action="end of minor GC",jvm_gc_name="G1 Young Generation",otel_scope_name="io.opentelemetry.runtime-telemetry-java17",otel_scope_version="2.14.0-alpha"} 0.013224165999999999
jvm_gc_duration_seconds_bucket{jvm_gc_action="end of minor GC",jvm_gc_name="G1 Young Generation",otel_scope_name="io.opentelemetry.runtime-telemetry-java8",otel_scope_version="2.14.0-alpha",le="0.01"} 3
jvm_gc_duration_seconds_bucket{jvm_gc_action="end of minor GC",jvm_gc_name="G1 Young Generation",otel_scope_name="io.opentelemetry.runtime-telemetry-java8",otel_scope_version="2.14.0-alpha",le="0.1"} 3
jvm_gc_duration_seconds_bucket{jvm_gc_action="end of minor GC",jvm_gc_name="G1 Young Generation",otel_scope_name="io.opentelemetry.runtime-telemetry-java8",otel_scope_version="2.14.0-alpha",le="1.0"} 3
jvm_gc_duration_seconds_bucket{jvm_gc_action="end of minor GC",jvm_gc_name="G1 Young Generation",otel_scope_name="io.opentelemetry.runtime-telemetry-java8",otel_scope_version="2.14.0-alpha",le="10.0"} 3
jvm_gc_duration_seconds_bucket{jvm_gc_action="end of minor GC",jvm_gc_name="G1 Young Generation",otel_scope_name="io.opentelemetry.runtime-telemetry-java8",otel_scope_version="2.14.0-alpha",le="+Inf"} 3
jvm_gc_duration_seconds_count{jvm_gc_action="end of minor GC",jvm_gc_name="G1 Young Generation",otel_scope_name="io.opentelemetry.runtime-telemetry-java8",otel_scope_version="2.14.0-alpha"} 3

Metric Reporters

Needs more research but possibly this goes away as well?

Grafana Dashboard

Consider introducing a new default Grafana dashboard to visualize metrics (potentially out of scope).

Compatibility, Deprecation, and Migration Plan

This change represents a significant update and will result in a break in backward compatibility, making it suitable only for major version releases. Users and applications relying on the metrics API will face compatibility issues, even if an OTel to Dropwizard shim is created, due to potential differences in naming conventions.

The Prometheus Exporter may be deprecated as it will no longer be needed. Users accessing the GET /admin/metrics?wt=prometheus API will not face disruptions, but they may need to update their PromQL queries for dashboards due to changes in metric names and tags.

Security considerations

This needs more research. Does OTLP support in-transit encryption such as TLS? Metrics could contain detailed information about the state of Solr. Maybe the metrics API should be bound to a separate port with auth and TLS.

Test Plan

Describe in few sentences how the SIP will be tested. We are mostly interested in system tests (since unit-tests are specific to implementation details). How will we know that the implementation works as expected? How will we know nothing broke?

[TBD]

Rejected Alternatives

If there are alternative ways of accomplishing the same thing, what were they? The purpose of this section is to motivate why the design is the way it is and not some other way.

  • No labels